Remove language server log preference #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbyIanna
force-pushed
the
remove-language-server-log
branch
from
cb6f134 to
b33cc30
Compare
per1234
added
topic: code
per1234
requested changes
Nov 27, 2021
There was a problem hiding this comment.
Please preserve support for enabling language server logging by setting the arduino.language.log settings key manually in settings.json.
The logging capabilities can still be useful for investigating reports of problems with the Arduino Language Server. In that case, we can guide the user in enabling the logging via the IDE's secondary advanced UI (or just using a text editor on settings.json). So there is no need to have a control for this via the IDE's primary UI, and this is why it should be removed from the File > Preferences interface.
AlbyIanna
force-pushed
the
remove-language-server-log
branch
from
b33cc30 to
807a318
Compare
|
@per1234 thank you for the hint. I've just re-enabled the option, now it can be toggled in the advanced settings but it's not shown in the main Preferences diaog. |
fstasi
approved these changes
Nov 29, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the
Enable language server loggingoption in the preferencesWhy
This option was needed in the early development and testing phase of the Arduino Language Server. However, this is not something the target user will ever have a need for, so it only makes the IDE less friendly.